Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix frontend deploy workflow #4977

Merged
merged 8 commits into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions .github/workflows/.reusable-frontend-deploy.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
# reusable workflow

on:
workflow_call:
inputs:
gh_environment:
type: string
description: Github environment to use for secret / variable access
required: true
npm_build_environment:
type: string
description: The environment set as the ENV environment variable when running npm run env
required: true

defaults:
run:
working-directory: frontend

jobs:
deploy:
runs-on: ubuntu-latest
environment: ${{ inputs.environment }}

permissions:
contents: read

steps:
- name: Cloning repo
uses: actions/checkout@v4

- name: Setup Node.js 16.x
uses: actions/setup-node@v4
with:
node-version: 16.x

- name: Cache dependencies
uses: actions/cache@v3
with:
path: ~/.npm
key: npm-${{ hashFiles('package-lock.json') }}
restore-keys: npm-

- name: Deploy to Vercel
env:
VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }}
VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }}
ENV: ${{ inputs.node_env }}
run: |
npm ci --only=prod
npm run env
npm run bundle
echo ${{ github.sha }} > CI_COMMIT_SHA
npm install --global [email protected]
vercel --prod --token ${{ secrets.VERCEL_TOKEN }}
73 changes: 8 additions & 65 deletions .github/workflows/frontend-deploy-production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ on:
- frontend/**
- .github/**

defaults:
run:
working-directory: frontend

jobs:
run-tests:
runs-on: ubuntu-latest
Expand All @@ -33,70 +29,17 @@ jobs:
environment: prod

deploy-production:
runs-on: ubuntu-latest
name: Deploy to Vercel Production
environment: production
needs: run-tests

steps:
- name: Cloning repo
uses: actions/checkout@v4

- name: Setup Node.js 16.x
uses: actions/setup-node@v4
with:
node-version: 16.x

- name: Cache dependencies
uses: actions/cache@v3
with:
path: ~/.npm
key: npm-${{ hashFiles('package-lock.json') }}
restore-keys: npm-

- name: Deploy to Vercel
env:
VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }}
VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }}
ENV: prod
run: |
npm ci --only=prod
npm run env
npm run bundle
echo ${{ github.sha }} > CI_COMMIT_SHA
vercel --prod --token ${{ secrets.VERCEL_TOKEN }}
uses: ./.github/workflows/.reusable-frontend-deploy.yml
with:
gh_environment: prod
npm_build_environment: prod

deploy-demo:
runs-on: ubuntu-latest
name: Deploy to Vercel Demo
environment: demo
needs: run-tests

steps:
- name: Cloning repo
uses: actions/checkout@v4

- name: Setup Node.js 16.x
uses: actions/setup-node@v4
with:
node-version: 16.x

- name: Cache dependencies
uses: actions/cache@v3
with:
path: ~/.npm
key: npm-${{ hashFiles('package-lock.json') }}
restore-keys: npm-

- name: Deploy to Vercel
env:
VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }}
VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }}
ENV: prod
run: |
npm ci --only=prod
npm run env
npm run bundle
echo ${{ github.sha }} > CI_COMMIT_SHA
npm install --global [email protected]
vercel --prod --token ${{ secrets.VERCEL_TOKEN }}
uses: ./.github/workflows/.reusable-frontend-deploy.yml
with:
gh_environment: demo
npm_build_environment: prod
Loading