Map to basesections reorganized 2 #427

RubelMozumder · 2024-09-11T09:08:56Z

No description provided.

src/pynxtools/nomad/schema.py

sanbrock

we can go with this, or we may want to activate the renaming function. See comments

…tions url

…ce work or not.

tests/nomad/test_parsing.py

sanbrock

LGTM

lukaspie mentioned this pull request Sep 11, 2024

New attempt: map to NOMAD basesections #419

Closed

RubelMozumder force-pushed the map-to-basesections-reorganized_2 branch from 685d374 to ccd81ef Compare September 11, 2024 10:29

RubelMozumder marked this pull request as ready for review September 11, 2024 10:30

sanbrock reviewed Sep 11, 2024

View reviewed changes

src/pynxtools/nomad/schema.py Outdated Show resolved Hide resolved

sanbrock reviewed Sep 11, 2024

View reviewed changes

src/pynxtools/nomad/schema.py Outdated Show resolved Hide resolved

sanbrock reviewed Sep 11, 2024

View reviewed changes

lukaspie and others added 24 commits September 12, 2024 09:41

import basesections

e94b706

initiate base section map

35b1356

implement mapping in __to_section

b532f64

type hinting

7bd19b3

name testing

af715bf

create own basesections with mapping

6fb0cd4

dynamically create class that inherits from base section

deb79bd

use base section mapping function

7a23859

add base section directly

86d3840

rename nexus to nomad.

76ac1aa

rename nexus to nomad.

4ed032b

harmonize collaborative work, functionality to get the correct defini…

b1deab7

…tions url

rename file with remote definitions url

1b5e669

add .txt to MANIFEST

de4aa07

test for definitions url retrieval

bb378ec

remove unneeded function

4f2efaa

Fix error Parsing NeXus file: Error from resolve_variadic_name function.

3fb908e

Test effort to fix error in parsing nexus file.

579795e

revert changes to parser

7c3e024

revert changes to parser

b850b8f

Nomad BaseSeection implemented properly.

341284c

Attempt: Add normalize function.

ec3a8a2

linting fix

fd71d09

reorganize, dont use new classes

f1ce2e8

lukaspie and others added 13 commits September 12, 2024 09:41

implement both options

49b8647

tests in schema.py

fe6cb1e

reasonable test for normalizing NXfabrication

9be00c3

ruff formatting

a0744ae

initial work on NXsample normalization

3f84666

Attempt to reference NXsample.

6042b99

lab_id can be populated properly, nut not sure CompositeSystemReferen…

60bd60a

…ce work or not.

reference aadding with lev and sandor

fe08109

RB

2c03ad1

creating Entity entries via json files

f69cad9

create proper Entity ELN

6e1cad5

Clean up schema.py

d61d387

converting NX to BS works properly in nexus parser.

704bf78

RubelMozumder force-pushed the map-to-basesections-reorganized_2 branch from 9932fc0 to 704bf78 Compare September 12, 2024 07:52

RubelMozumder added 2 commits September 12, 2024 10:27

test fix.

620ce87

typo and test.

fde8058

sanbrock reviewed Sep 12, 2024

View reviewed changes

tests/nomad/test_parsing.py Outdated Show resolved Hide resolved

sanbrock reviewed Sep 12, 2024

View reviewed changes

tests/nomad/test_parsing.py Outdated Show resolved Hide resolved

sanbrock reviewed Sep 12, 2024

View reviewed changes

tests/nomad/test_parsing.py Outdated Show resolved Hide resolved

automat prefix of base classes and application definition.

e602092

sanbrock approved these changes Sep 12, 2024

View reviewed changes

RubelMozumder merged commit d32cb0e into master Sep 13, 2024
12 checks passed

RubelMozumder deleted the map-to-basesections-reorganized_2 branch September 27, 2024 07:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Map to basesections reorganized 2 #427

Map to basesections reorganized 2 #427

RubelMozumder commented Sep 11, 2024

sanbrock left a comment

sanbrock left a comment

Map to basesections reorganized 2 #427

Map to basesections reorganized 2 #427

Conversation

RubelMozumder commented Sep 11, 2024

sanbrock left a comment

Choose a reason for hiding this comment

sanbrock left a comment

Choose a reason for hiding this comment