Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New attempt: map to NOMAD basesections #419

Closed
wants to merge 34 commits into from
Closed

New attempt: map to NOMAD basesections #419

wants to merge 34 commits into from

Conversation

lukaspie
Copy link
Collaborator

@lukaspie lukaspie commented Sep 6, 2024 •
edited
Loading

EDIT: this is the branch that we want to work on going forward
Made a new branch so that we don't loose too much on the other branch.

  • NXobject does not inherit any BaseSection (and thus does not have normalization)
  • We don't create any new classes for the normalization any more, but only add normalize functions (using super(self.__class__, self)). This should work since we now don't run into any recursion problems anymore.
  • All non NX-object NeXus classes inherit from one of the existing base sections once again

lukaspie and others added 29 commits September 2, 2024 09:01
@lukaspie
import basesections
d7b7bf2
@lukaspie
initiate base section map
017ea57
@lukaspie
implement mapping in __to_section
f15f3d3
@lukaspie
type hinting
609c688
@lukaspie
name testing
8ac181f
@lukaspie
create own basesections with mapping
55a4949
@lukaspie
dynamically create class that inherits from base section
f456c44
@lukaspie
use base section mapping function
7fcabc5
@lukaspie
add base section directly
83c90f8
@RubelMozumder
rename nexus to nomad.
c3f9308
@RubelMozumder
rename nexus to nomad.
4e4057f
@lukaspie
harmonize collaborative work, functionality to get the correct defini…
98e15a0 
…tions url
@lukaspie
rename file with remote definitions url
ed958dd
@lukaspie
add .txt to MANIFEST
cec3753
@lukaspie
test for definitions url retrieval
32d2ddc
@lukaspie
remove unneeded function
b3d978f
@RubelMozumder
Fix error Parsing NeXus file: Error from resolve_variadic_name function.
6ab0ce4
@RubelMozumder
Test effort to fix error in parsing nexus file.
edace9c
@lukaspie
revert changes to parser
906f593
@lukaspie
revert changes to parser
d71fdc4
@RubelMozumder
Nomad BaseSeection implemented properly.
6bbcfdf
@RubelMozumder
Attempt: Add normalize function.
f5de6c9
@lukaspie
linting fix
ce39260
@lukaspie
reorganize, dont use new classes
e88f39a
@lukaspie
implement both options
23f3a1c
@GinzburgLev
tests in schema.py
cc7b419
@sanbrock
reasonable test for normalizing NXfabrication
6b7a661
@lukaspie
ruff formatting
1cb5195
@lukaspie
initial work on NXsample normalization
8019a73
@lukaspie lukaspie mentioned this pull request Sep 9, 2024
Closed
@lukaspie lukaspie changed the title New attempt: map to basesections New attempt: map to NOMAD basesections Sep 9, 2024
@lukaspie
Copy link
Collaborator Author

Closed in favor of #427

@lukaspie lukaspie closed this Sep 11, 2024
@lukaspie lukaspie deleted the map-to-basesections-reorganized branch September 11, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukaspie @RubelMozumder @GinzburgLev @sanbrock