Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Build progress bar only on first update #3626

Merged
merged 4 commits into from
Dec 21, 2024

still clear it, but up the update interval

4ba1200
Select commit
Loading
Failed to load commit list.
Merged

chore: Build progress bar only on first update #3626

still clear it, but up the update interval
4ba1200
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 19, 2024 in 1s

77.88% (+0.07%) compared to 063de4d

View this Pull Request on Codecov

77.88% (+0.07%) compared to 063de4d

Details

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 77.88%. Comparing base (063de4d) to head (4ba1200).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
daft/runners/progress_bar.py 0.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3626      +/-   ##
==========================================
+ Coverage   77.80%   77.88%   +0.07%     
==========================================
  Files         718      719       +1     
  Lines       88250    88420     +170     
==========================================
+ Hits        68666    68862     +196     
+ Misses      19584    19558      -26
Files with missing lines Coverage Δ
src/daft-local-execution/src/progress_bar.rs 62.22% <ø> (ø)
daft/runners/progress_bar.py 57.29% <0.00%> (-6.67%) ⬇️

... and 15 files with indirect coverage changes

View more details on Codecov