Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Build progress bar only on first update #3626

Merged
merged 4 commits into from
Dec 21, 2024

no initial message

4404309
Select commit
Loading
Failed to load commit list.
Merged

chore: Build progress bar only on first update #3626

no initial message
4404309
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 21, 2024 in 0s

77.90% (+0.09%) compared to 063de4d

View this Pull Request on Codecov

77.90% (+0.09%) compared to 063de4d

Details

Codecov Report

Attention: Patch coverage is 16.66667% with 15 lines in your changes missing coverage. Please review.

Project coverage is 77.90%. Comparing base (063de4d) to head (4404309).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
daft/runners/progress_bar.py 6.66% 14 Missing ⚠️
src/daft-local-execution/src/progress_bar.rs 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3626      +/-   ##
==========================================
+ Coverage   77.80%   77.90%   +0.09%     
==========================================
  Files         718      720       +2     
  Lines       88250    88726     +476     
==========================================
+ Hits        68666    69122     +456     
- Misses      19584    19604      +20     
Files with missing lines Coverage Δ
src/daft-local-execution/src/lib.rs 95.45% <100.00%> (-0.09%) ⬇️
src/daft-local-execution/src/progress_bar.rs 63.52% <50.00%> (+1.30%) ⬆️
daft/runners/progress_bar.py 57.29% <6.66%> (-6.67%) ⬇️

... and 25 files with indirect coverage changes