Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized triggerDescriptorUpdate manipulation to multiple ReportParts. #64

Merged

Conversation

ben-Draeger
Copy link
Collaborator

@ben-Draeger ben-Draeger commented Sep 6, 2023

In order to Fix a Defect in SDCcc's Test case for Biceps:R5025, I had to generalize this Manipulation.

Checklist

The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer:

  • Changelog update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • README update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer

CHANGELOG.md Outdated Show resolved Hide resolved
src/t2iapi/device/service.proto Outdated Show resolved Hide resolved
Copy link
Collaborator

@maximilianpilz maximilianpilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

// Describe the purpose of the pull request here and remove this line. Keep the checklist.

from the initial comment.

src/t2iapi/device/service.proto Outdated Show resolved Hide resolved
src/t2iapi/device/device_requests.proto Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@maximilianpilz maximilianpilz merged commit fd114c1 into Draegerwerk:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants