Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized triggerDescriptorUpdate manipulation to multiple ReportParts. #64

Merged
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
SetMetricValuesWithQualityMode
- semantics for SetDeviceOperatingMode manipulation
- message PartialIdentification to message PartialInstanceIdentifier
- generalized triggerDescriptorUpdate manipulation to multiple ReportParts
ben-Draeger marked this conversation as resolved.
Show resolved Hide resolved

### Removed

Expand Down
7 changes: 7 additions & 0 deletions src/t2iapi/device/device_requests.proto
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,10 @@ message SetBatteryUsageRequest {
// electrical power source
bool use = 2; // specifies whether the battery shall be used as the electrical power source
}

/*
Request a DescriptionModificationReport with (multiple) Upt-ReportParts.
ben-Draeger marked this conversation as resolved.
Show resolved Hide resolved
*/
message TriggerDescriptorUpdateRequest{
repeated string handle = 1;
}
10 changes: 6 additions & 4 deletions src/t2iapi/device/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ service DeviceService {
and whose descriptors are of the given class.
Includes handles which have been removed already and can be reinserted.
Handles must stay the same once reinserted into the MDIB.
NOTE: When the requirement Biceps:R5025 is applicable to a Device, it is advisable to have at least one
maximilianpilz marked this conversation as resolved.
Show resolved Hide resolved
removable descriptor that has children.

Calling GetRemovableDescriptorsOfClass with descriptor_class = DESCRIPTOR_CLASS_ABSTRACT
returns the unfiltered handles while other values for descriptor_class
Expand Down Expand Up @@ -89,11 +91,11 @@ service DeviceService {
rpc RemoveMdsDescriptor (BasicHandleRequest) returns (BasicResponse);

/*
Trigger a descriptor update for the provided handle.
This manipulation of the device shall result in a msg:DescriptionModificationReport message with a report part with
modification type upt.
Trigger a descriptor update for the provided handles.
This manipulation of the device shall result in a msg:DescriptionModificationReport message with one report part with
modification type upt for each handle provided.
ben-Draeger marked this conversation as resolved.
Show resolved Hide resolved
*/
rpc TriggerDescriptorUpdate (BasicHandleRequest) returns (BasicResponse);
rpc TriggerDescriptorUpdate (TriggerDescriptorUpdateRequest) returns (BasicResponse);

/*
Trigger a descriptor update.
Expand Down