Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized triggerDescriptorUpdate manipulation to multiple ReportParts. #64

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
SetMetricValuesWithQualityMode
- semantics for SetDeviceOperatingMode manipulation
- message PartialIdentification to message PartialInstanceIdentifier
- TriggerDescriptorUpdate to request an update for an arbitrary amount of handles

### Removed

Expand Down
14 changes: 14 additions & 0 deletions src/t2iapi/device/device_requests.proto
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,17 @@ message SetBatteryUsageRequest {
// electrical power source
bool use = 2; // specifies whether the battery shall be used as the electrical power source
}

/*
Request a DescriptionModificationReport that fulfills the following:

For each given handle there exists an "Upt"-ReportPart that contains an updated descriptor, whose @DescriptorHandle
is equal to the given handle, and that is contained in the DescriptionModificationReport.

---

Note that when no handle is given, every DescriptionModificationReport fulfills the request.
*/
message TriggerDescriptorUpdateRequest{
repeated string handle = 1;
}
13 changes: 9 additions & 4 deletions src/t2iapi/device/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,16 @@ service DeviceService {
rpc RemoveMdsDescriptor (BasicHandleRequest) returns (BasicResponse);

/*
Trigger a descriptor update for the provided handle.
This manipulation of the device shall result in a msg:DescriptionModificationReport message with a report part with
modification type upt.
Trigger a DescriptionManipulationReport that fulfills the following:

For each given handle there exists an "Upt"-ReportPart that contains an updated descriptor, whose @DescriptorHandle
is equal to the given handle, and that is contained in the DescriptionModificationReport.

---

Note that when no handle is given, every DescriptionModificationReport fulfills the request.
*/
rpc TriggerDescriptorUpdate (BasicHandleRequest) returns (BasicResponse);
rpc TriggerDescriptorUpdate (TriggerDescriptorUpdateRequest) returns (BasicResponse);

/*
Trigger a descriptor update.
Expand Down