-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
my first encoding #20
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start, with some room for improvement 😄
<entry xml:id="mosaico" xml:lang="sp"> | ||
<form type="lemma"><orth norm="mosaico">mosaico</orth></form> | ||
<gramGrp> | ||
<pos norm="NOUN">n.</pos> <pos norm="SING">s.</pos> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A noun is a part of speech, but singular is a number, not part of speech. Furthermore, I'm not sure that n.s. means noun singular. I bet it's nomen substantivum, which is really just a noun in Latin. So I would check the introduction of your dictionary just to be sure.
If it was noun singular then I would suggest <gram type="pos" norm="NOUN">noun</gram> <gram type="number">singular</gram>
.
<pos norm="NOUN">n.</pos> <pos norm="SING">s.</pos> | ||
</gramGrp> | ||
<pc>(</pc> | ||
<etym><cit type="etymon" xml:lang="en"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these etymologies or translation equivalents?
<form><orth>mosaic</orth></form> | ||
</cit><pc>;</pc> | ||
<cit type="etymon" xml:lang="ge"> | ||
<form><orth>Kleinmosaik, Mosaikfliese</orth></form> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regardless of whether these are etymons or translationEquivalents, it would be better to put each of these words as <form><orth></orth></form>
. Otherwise you would be implying that "Kleinmosaik, Mosaikfliese" is one word.
No description provided.