Endo integration scratch PR #9385
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
added a commit
to endojs/endo
that referenced
this pull request
May 21, 2024
refs: #1488 ## Description Simplify build by using NPM lifecycle hooks. Adds a CI test for the package graph sensitivity that the extant method was checking. Part of making it work was adding "typescript" to `devDependencies` of packages that need it. The root `build:types` was running with the root `tsc` but when building in each package separately they wouldn't get the root's typescript version and fall back to the global one, which didn't know the `@import` syntax. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations Less to document ### Testing Considerations I tried the "publish" commands in CONTRIBUTING.md. integration PR in agoric-sdk: Agoric/agoric-sdk#9385 ### Compatibility Considerations Removes a necessary accommodation on agoric-sdk ### Upgrade Considerations None
turadg
force-pushed
the
endo-integration-temp
branch
from
2ec0ecf to
56384d1
Compare
Deploying agoric-sdk with
|
| Latest commit: |
a347ffb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4cc9a869.agoric-sdk.pages.dev |
| Branch Preview URL: | https://endo-integration-temp.agoric-sdk.pages.dev |
turadg
force-pushed
the
endo-integration-temp
branch
from
56384d1 to
90d3c98
Compare
michaelfig
force-pushed
the
endo-integration-temp
branch
from
90d3c98 to
8da1321
Compare
turadg
commented
Aug 19, 2024
scripts/registry.sh
Outdated
Comment on lines
98
to
97
| # Convention used in Endo | ||
| yarn lerna run clean:types |
There was a problem hiding this comment.
this isn't necessary anymore https://github.com/search?q=repo%3Aendojs%2Fendo%20clean%3Atypes&type=code
mergify bot
added a commit
that referenced
this pull request
Aug 21, 2024
#endo-branch: master ## Description Removes some build code that references Endo code that's no longer there. Also slips in a typedefs fix to re-spin CI after I changed the endo-branch target. These fixes are good to get in ASAP and didn't seem worth a whole other PR. After this merges I think #9385 can be reset to master ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations CI suffices ### Upgrade Considerations none
turadg
force-pushed
the
endo-integration-temp
branch
from
8da1321 to
dfc7a48
Compare
|
Accidentally closed by a PR comment |
turadg
force-pushed
the
endo-integration-temp
branch
from
11f2800 to
f175afd
Compare
turadg
force-pushed
the
endo-integration-temp
branch
from
f175afd to
437c03b
Compare
turadg
force-pushed
the
endo-integration-temp
branch
from
e1bc7f6 to
1db9337
Compare
turadg
force-pushed
the
endo-integration-temp
branch
from
1db9337 to
a347ffb
Compare
turadg
added a commit
to endojs/endo
that referenced
this pull request
Oct 18, 2024
_incidental_ ## Description In an a3p test I tried disabling `skipLibCheck` and many errors were from Endo packages's omission of module filename extensions. That's because Endo was using the default [moduleResolution](https://www.typescriptlang.org/tsconfig/#moduleResolution), `node10`. This changes it to `NodeNext` and also the `module` option for compatibility. That resulted in new errors which I address mostly by switching to explicit `@import`. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations - Agoric/agoric-sdk#9385 ### Compatibility Considerations This might affect consuming packages that depend on ambient types. That's almost certainly only agoric-sdk which we can solve with Agoric/agoric-sdk#9385 ### Upgrade Considerations If Agoric/agoric-sdk#9385 needs changes then `NEWS.md` should indicate it. I don't think type changes live up to `BREAKING` which would be a semver major bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#endo-branch: master
Description
Persistent scratch PR for testing Endo integration, using
agoric-sdk/.github/actions/restore-node/action.yml
Lines 57 to 61 in d3a9dd4
#9285 is an example of how it works. This PR should never leave draft because it's never meant to merge, just test. It should never be closed, so that we can use it again and again for different Endo branches.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations