adopt workspace protocol #2293
Closed
adopt workspace protocol #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
ta/workspace-protocol
branch
2 times, most recently
from
a573331 to
7c1aaf0
Compare
kriskowal
requested changes
May 21, 2024
turadg
force-pushed
the
ta/workspace-protocol
branch
from
7c1aaf0 to
dfa7761
Compare
kriskowal
approved these changes
May 21, 2024
|
Solved by @michaelfig in #2416 |
I really didn't search for the right terms when I was trying to check for prior work. Sorry for being pushy. : |
No problem! I'm happy for it to be done. I thought Lerna was the reason I dropped this back to draft but it might have been this:
Sorry I didn't find that earlier. I'm afraid you might run into it. Of course it would be great if you also just solved, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: Agoric/agoric-sdk#9209, Agoric/agoric-sdk#9288
Description
Uses the workspace: protocol to distinguish dependencies on local package with those from a registry.
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
not user facing
Testing Considerations
yarn lerna version --no-push --conventional-graduate --no-git-tag-versionproduces correct versionsyarn lerna exec yarn pack. Untarred one and verified its package.json references version numbers for other monorepo packages.getting-startedwhich failed last time)Compatibility Considerations
n/a
Upgrade Considerations
n/a