Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce Endo build coupling #9395

Merged
merged 2 commits into from
Aug 21, 2024
Merged

reduce Endo build coupling #9395

merged 2 commits into from
Aug 21, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented May 21, 2024

#endo-branch: master

Description

Removes some build code that references Endo code that's no longer there.

Also slips in a typedefs fix to re-spin CI after I changed the endo-branch target. These fixes are good to get in ASAP and didn't seem worth a whole other PR.

After this merges I think #9385 can be reset to master

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

none

Testing Considerations

CI suffices

Upgrade Considerations

none

Copy link

cloudflare-workers-and-pages bot commented May 21, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: b117ef8
Status: ✅  Deploy successful!
Preview URL: https://76f5f585.agoric-sdk.pages.dev
Branch Preview URL: https://ta-endo-integration.agoric-sdk.pages.dev

View logs

@turadg turadg force-pushed the ta/endo-integration branch from d414142 to 5c1e2f6 Compare August 20, 2024 22:36
@turadg turadg marked this pull request as ready for review August 20, 2024 23:01
@turadg turadg requested review from kriskowal and michaelfig August 20, 2024 23:01
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Clear for takeoff. 🚀

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Aug 21, 2024
@mergify mergify bot merged commit dfc7a48 into master Aug 21, 2024
100 checks passed
@mergify mergify bot deleted the ta/endo-integration branch August 21, 2024 14:23
Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants