remove xs:unit testing #10207
Merged
remove xs:unit testing #10207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
approved these changes
Oct 3, 2024
|
p.s. I think ava-xs contorts our dependency tree. It should be in its own package. Which would mean this PR might prune that package. Including it in the xsnap package adds otherwise irrelevant dependencies to xsnap. IOU an issue. not confident I'll find time to collect details to file it, though. |
Deploying agoric-sdk with
|
| Latest commit: |
96f737e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://723de6d9.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-no-xs-unit.agoric-sdk.pages.dev |
toliaqat
approved these changes
Oct 3, 2024
There are few to no errors we've detected in unit tests running in XS that we didn't in Node. We now have many other tests that run XS and don't need to unit test these. It generally doesn't hurt to test more, but ava-xs is so different from XS that the cost of reconciliation is too great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidental
Description
While working on #10202 I got a CI error that "no function" for the Zoe tests. It turned out to be that ava-xs doesn't support
t.snapshot. So I added it to the voluminous "exclude" value and pushed again. Later I see CI fails again because ava-xs is confused by thesnapshotsdirectory.The
test:xs-unitjob is not carrying its weight. I can't recall it ever detecting an error that wasn't detected in Node. Maybe a while ago it did and it was an important line of defense. In the past year we've developed much more integration testing and I'm confident these tests are redundant.It generally doesn't hurt to test more, but ava-xs is so different from XS that the cost of reconciliation is too great.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
see above
Upgrade Considerations
none