-
Notifications
You must be signed in to change notification settings - Fork 214
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
incidental ## Description While working on #10202 I got a CI error that "no function" for the Zoe tests. It turned out to be that ava-xs doesn't support `t.snapshot`. So I added it to the voluminous "exclude" value and pushed again. Later I see CI [fails again](https://github.com/Agoric/agoric-sdk/actions/runs/11162498228/job/31027478876?pr=10202) because ava-xs is confused by the `snapshots` directory. The `test:xs-unit` job is not carrying its weight. I can't recall it ever detecting an error that wasn't detected in Node. Maybe a while ago it did and it was an important line of defense. In the past year we've developed much more integration testing and I'm confident these tests are redundant. It generally doesn't hurt to test more, but ava-xs is so different from XS that the cost of reconciliation is too great. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations see above ### Upgrade Considerations none
- Loading branch information
Showing
3 changed files
with
5 additions
and
59 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters