Skip to content

Commit

Permalink
ci: drop xs:unit job
Browse files Browse the repository at this point in the history
There are few to no errors we've detected in unit tests running in XS that we didn't in Node. We now have many other tests that run XS and don't need to unit test these. It generally doesn't hurt to test more, but ava-xs is so different from XS that the cost of reconciliation is too great.
  • Loading branch information
turadg committed Oct 3, 2024
1 parent ac039f4 commit aa98c30
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 58 deletions.
13 changes: 1 addition & 12 deletions packages/ERTP/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@
"postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'",
"test": "ava",
"test:c8": "c8 $C8_OPTIONS ava",
"test:xs": "yarn test:xs-unit && yarn test:xs-worker",
"test:xs-unit": "ava-xs",
"test:xs-worker": "SWINGSET_WORKER_TYPE=xs-worker ava -c 2 test/swingsetTests",
"test:xs": "SWINGSET_WORKER_TYPE=xs-worker ava -c 2 test/swingsetTests",
"lint-fix": "yarn lint:eslint --fix",
"lint": "run-s --continue-on-error lint:*",
"lint:eslint": "eslint .",
Expand Down Expand Up @@ -64,15 +62,6 @@
"exported.js",
"exported.d.ts"
],
"ava-xs": {
"exclude": [
"swingsetTests",
"# fast-check unsupported",
"test/unitTests/amountProperties.test.js",
"test/unitTests/inputValidation.test.js",
"test/unitTests/issuerObj.test.js"
]
},
"ava": {
"files": [
"test/**/*.test.*"
Expand Down
47 changes: 1 addition & 46 deletions packages/zoe/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@
"test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
"test:unit": "ava 'test/unitTests' -T 1m --verbose",
"test:swingset": "ava 'test/swingsetTests' -T 10m --verbose",
"test:xs": "yarn test:xs-unit && yarn test:xs-worker",
"test:xs-unit": "ava-xs --verbose",
"test:xs-worker": "SWINGSET_WORKER_TYPE=xs-worker ava -c 2 'test/swingsetTests'",
"test:xs": "SWINGSET_WORKER_TYPE=xs-worker ava -c 2 'test/swingsetTests'",
"build-zcfBundle": "yarn build:bundles",
"lint-fix": "yarn lint:eslint --fix",
"lint": "run-s --continue-on-error lint:*",
Expand Down Expand Up @@ -85,49 +83,6 @@
"exported.js",
"NEWS.md"
],
"ava-xs": {
"exclude": [
"# path/url/import.meta stuff",
"unitTests/contracts/",
"test/swingsetTests/privateArgs/privateArgs.test.js",
"test/swingsetTests/brokenContracts/crashingContract.test.js",
"test/swingsetTests/offerArgs/offerArgs.test.js",
"test/swingsetTests/makeKind/makeKind.test.js",
"test/swingsetTests/zoe/zoe.test.js",
"test/swingsetTests/runMint/runMint.test.js",
"test/unitTests/zoe.test.js",
"test/unitTests/scriptedOracle.test.js",
"test/unitTests/makeKind.test.js",
"test/unitTests/instanceStorage.test.js",
"test/unitTests/contractSupport/depositTo.test.js",
"test/unitTests/contractSupport/withdrawFrom.test.js",
"test/unitTests/contractSupport/offerTo.test.js",
"test/unitTests/zcf/zcfSeat.test.js",
"test/unitTests/zcf/zcfSeat-exit.test.js",
"test/unitTests/zcf/setupZcfTest.js",
"test/unitTests/zcf/feeMintAccess.test.js",
"# import.meta.url by way of setupZcfTest",
"test/unitTests/zoe.test.js",
"test/unitTests/zoe-startInstance.test.js",
"test/unitTests/blockedOffers.test.js",
"test/unitTests/zcf/reallocate-empty.test.js",
"test/unitTests/zcf/zoeHelpersWZcf.test.js",
"test/unitTests/zcf/reallocateForZCFMint.test.js",
"test/unitTests/zcf/atomicRearrange.test.js",
"test/unitTests/zcf/zcf.test.js",
"test/unitTests/zcf/allStagedSeatsUsed.test.js",
"# ManualTimer.setWakeup: no function",
"test/unitTests/fakePriceAuthority.test.js",
"test/unitTests/manualTimer.test.js",
"# hangs",
"makeKind.test.js",
"test/unitTests/scriptedOracle.test.js",
"test/unitTests/zoe.test.js",
"test/unitTests/zcf/allStagedSeatsUsed.test.js",
"# We use SWINGSET_WORKER_TYPE=xs ava to run these...",
"swingsetTests"
]
},
"ava": {
"files": [
"test/**/*.test.*"
Expand Down

0 comments on commit aa98c30

Please sign in to comment.