Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use formatted text view for attributed text editing #991

Merged
merged 12 commits into from
Aug 23, 2024
Merged

Use formatted text view for attributed text editing #991

merged 12 commits into from
Aug 23, 2024

Commits on Aug 19, 2024

  1. Refactor AnnotationTextView

    @mvasilak
    mvasilak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5f59773 View commit details
    Browse the repository at this point in the history

  2. Refactor HighlightEditCell

    @mvasilak
    mvasilak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2a43fad View commit details
    Browse the repository at this point in the history

  3. Fix AnnotationEditViewController memory leak

    @mvasilak
    mvasilak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bab2022 View commit details
    Browse the repository at this point in the history

  4. Refactor AnnotationTextView to FormattedTextView 

    Move menu items from PlaceholderTextViewDelegate to FormattedTextView
    @mvasilak
    mvasilak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f64cebb View commit details
    Browse the repository at this point in the history

  5. Use FormattedTextView for item title editing 

    Move PlaceholderTextViewDelegate observers to FormattedTextView
Refactor ItemDetailTitleContentView
    @mvasilak
    mvasilak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    17e5579 View commit details
    Browse the repository at this point in the history

  6. Update tests

    @mvasilak
    mvasilak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b1d5af5 View commit details
    Browse the repository at this point in the history

  7. Fix HtmlAttributedStringConverterSpec edge case

    @mvasilak
    mvasilak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b02a593 View commit details
    Browse the repository at this point in the history

  8. Use FormattedTextView for annotation text editing

    @mvasilak
    mvasilak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e7cd6aa View commit details
    Browse the repository at this point in the history

  9. Remove any formatting from item note editor title

    @mvasilak
    mvasilak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    39e8ae2 View commit details
    Browse the repository at this point in the history

  10. Improve code

    @mvasilak
    mvasilak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bd66009 View commit details
    Browse the repository at this point in the history

  11. Improve AnnotationEditSaveAction closure

    @mvasilak
    mvasilak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    6ce8a60 View commit details
    Browse the repository at this point in the history

  12. Fix item detail title text view updates 

    Improve formatted text view observers
Fix text view placeholder appearance
    @mvasilak
    mvasilak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    df388fd View commit details
    Browse the repository at this point in the history