Use formatted text view for attributed text editing #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalrentka
reviewed
Aug 9, 2024
Zotero/Scenes/Detail/Annotation Popover/Views/AnnotationEditViewController.swift
Outdated
Show resolved
Hide resolved
Zotero/Scenes/Detail/Annotation Popover/Views/AnnotationEditViewController.swift
Show resolved
Hide resolved
Zotero/Scenes/Detail/Annotation Popover/Views/HighlightEditCell.swift
Outdated
Show resolved
Hide resolved
Zotero/Scenes/Detail/Annotation Popover/Views/HighlightEditCell.swift
Outdated
Show resolved
Hide resolved
Zotero/Scenes/Detail/ItemDetail/Views/ItemDetailTitleContentView.swift
Outdated
Show resolved
Hide resolved
mvasilak
force-pushed
the
add-generic-formatted-text-view
branch
2 times, most recently
from
88b9ccf
to
0f2c1d5
Compare
Move menu items from PlaceholderTextViewDelegate to FormattedTextView
Move PlaceholderTextViewDelegate observers to FormattedTextView Refactor ItemDetailTitleContentView
Improve formatted text view observers Fix text view placeholder appearance
mvasilak
force-pushed
the
add-generic-formatted-text-view
branch
from
2f13efe
to
df388fd
Compare
michalrentka
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #990