Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5 - Update subscription.rb to throw abort on callback chain when false is returned #361

Conversation

yuenmichelle1
Copy link
Collaborator

@yuenmichelle1 yuenmichelle1 commented Aug 19, 2024

Rails 5 deprecated behavior. Update subscription.rb to throw abort on callback chain when false is returned.

See: https://www.bigbinary.com/blog/rails-5-does-not-halt-callback-chain-when-false-is-returned and following deprecation warning on rails 5

DEPRECATION WARNING: Returning `false` in Active Record and Active Model callbacks will not implicitly halt a callback chain in Rails 5.1. To explicitly halt the callback chain, please use `throw :abort` instead. (called from block (4 levels) in <top (required)> at /home/runner/work/talk-api/talk-api/spec/models/subscription_spec.rb:70)

Also adding version constraints on rspec-rails. rspec-rails 5.0 not compatible with rails <= 5.1 but will be compatible with rails 5.2, see https://github.com/rspec/rspec-rails/blob/v5.0.0/Changelog.md#500--2021-03-09

@yuenmichelle1 yuenmichelle1 marked this pull request as ready for review August 19, 2024 19:15
@yuenmichelle1 yuenmichelle1 requested a review from Tooyosi August 19, 2024 19:15
@yuenmichelle1 yuenmichelle1 merged commit dae01d3 into master Aug 22, 2024
1 of 2 checks passed
@yuenmichelle1 yuenmichelle1 deleted the rails-5---deprecated-behavior-callback-chain-does-not-halt-if-false-is-returned branch September 23, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant