Rails 5 - Update subscription.rb to throw abort on callback chain when false is returned #361
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5 deprecated behavior. Update subscription.rb to throw abort on callback chain when false is returned.
See: https://www.bigbinary.com/blog/rails-5-does-not-halt-callback-chain-when-false-is-returned and following deprecation warning on rails 5
Also adding version constraints on rspec-rails. rspec-rails 5.0 not compatible with rails <= 5.1 but will be compatible with rails 5.2, see https://github.com/rspec/rspec-rails/blob/v5.0.0/Changelog.md#500--2021-03-09