Update subscription.rb to throw abort on callback chain when false is…

… returned (#361) See: https://www.bigbinary.com/blog/rails-5-does-not-halt-callback-chain-when-false-is-returned
zooniverse · Aug 22, 2024 · dae01d3 · dae01d3
1 parent d06bfe5
commit dae01d3
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/Gemfile b/Gemfile
@@ -38,7 +38,7 @@ group :test, :development do
   gem 'guard-rspec'
   gem 'pry'
   gem 'rspec-its'
-  gem 'rspec-rails'
+  gem 'rspec-rails', '~> 4.1.2'
   gem 'spring-commands-rspec'
   gem 'ten_years_rails'
   gem 'timecop'

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -389,7 +389,7 @@ DEPENDENCIES
   redis (~> 3.3.0)
   restpack_serializer!
   rspec-its
-  rspec-rails
+  rspec-rails (~> 4.1.2)
   schema_plus_pg_indexes
   sidekiq (< 6)
   sidekiq-congestion (~> 0.1.0)

diff --git a/Gemfile.next.lock b/Gemfile.next.lock
@@ -389,7 +389,7 @@ DEPENDENCIES
   redis (~> 3.3.0)
   restpack_serializer!
   rspec-its
-  rspec-rails
+  rspec-rails (~> 4.1.2)
   schema_plus_pg_indexes
   sidekiq (< 6)
   sidekiq-congestion (~> 0.1.0)

diff --git a/app/models/subscription.rb b/app/models/subscription.rb
@@ -17,7 +17,7 @@ def preference
   end
 
   def ensure_enabled
-    preference.enabled?
+    throw(:abort) unless preference.enabled?
   end
 
   def enabled?