Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary notice banner to app layouts for scheduled downtime #6456

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

goplayoutside3
Copy link
Contributor

@goplayoutside3 goplayoutside3 commented Nov 12, 2024

Package

app-project
app-root

Linked Issue and/or Talk Post

Slack: https://zooniverse.slack.com/archives/C4RJRAGKA/p1731079514305719
Corresponds to: zooniverse/Panoptes-Front-End#7217

Describe your changes

  • Add html and css for a simple <details> and <summary> at the top of each layout.

How to Review

  • I will likely end up just self-reviewing and merging this due to its simplicity and non-permanence.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out
  • The component is accessible

@goplayoutside3
Copy link
Contributor Author

Here's some screenshots:

app-project notice collapsed

app-project notice expanded

@coveralls
Copy link

coveralls commented Nov 12, 2024

Coverage Status

coverage: 77.563% (-0.03%) from 77.596%
when pulling 813bfbc on temp-notice-banner
into c48e590 on master.

@shaunanoordin shaunanoordin self-requested a review November 12, 2024 21:52
@shaunanoordin shaunanoordin self-assigned this Nov 12, 2024
Copy link
Member

@shaunanoordin shaunanoordin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

Packages: app-root, app-project

This PR adds a (temporary) notice banner to the FEM root page, and FEM project pages.

  • HTML code looks good.
  • Rendered HTML component on the pages look good.
    • The <details> element renders fine and can be expanded to view all the details.
    • Tested on localhost: signed-in home page (app-root), random test project's project page (app-project).
    • Tested with Chrome.
  • Content looks good.
    • Text looks correct (no typoss) and legit (downtime is Wed 20 Nov, OK), with no mistakes noted.
    • Links work as expected.
  • Accessibility looks fine, I think.
    • The <details> element be be expanded & navigated via keyboard.

Status

LGTM 👍

@github-actions github-actions bot added the approved This PR is approved for merging label Nov 12, 2024
@goplayoutside3 goplayoutside3 merged commit 7b9879d into master Nov 13, 2024
8 checks passed
@goplayoutside3 goplayoutside3 deleted the temp-notice-banner branch November 13, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants