Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a temporary notice banner to the layout #7217

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

goplayoutside3
Copy link
Contributor

@goplayoutside3 goplayoutside3 commented Nov 12, 2024

Staging branch URL: https://pr-7217.pfe-preview.zooniverse.org/projects

Linked Issues

Corresponds to: zooniverse/front-end-monorepo#6456
Slack: https://zooniverse.slack.com/archives/C4RJRAGKA/p1731079514305719

Changes

  • Add html and css for a simple <details> and <summary> at the top of each layout.
  • 🗒️ Noting that I am not using the existing AppStatus component in this repo because that banner is sticky and disruptive to users who have to close it each time they visit the site.

Review Checklist

I will likely end up just self-reviewing and merging this due to its simplicity and non-permanence.

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

@goplayoutside3
Copy link
Contributor Author

Here's some screenshots:

Screenshot 2024-11-12 at 3 03 48 PM
Screenshot 2024-11-12 at 3 03 59 PM

@coveralls
Copy link

Coverage Status

coverage: 56.663% (-0.02%) from 56.68%
when pulling 9883bdd on temp-notice-banner
into 70b8a44 on master.

@shaunanoordin shaunanoordin self-requested a review November 12, 2024 21:53
@shaunanoordin shaunanoordin self-assigned this Nov 12, 2024
Copy link
Member

@shaunanoordin shaunanoordin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

This PR adds a (temporary) notice banner to PFE pages.

  • HTML code looks good.
  • Rendered HTML component on the pages look good.
    • The <details> element renders fine and can be expanded to view all the details.
    • Tested on staging branch: projects page, a random project's project page, a random project's Talk page.
    • Tested with Chrome, FF, and Safari.
  • Content looks good.
    • Text looks correct (no typpos) and legit (downtime is Wed 20 Nov, yup), with no mistakes detected.
    • Links work as expected. (Note: nofollow/noreferrer isn't required in this case, this is fine.)
  • Accessibility looks fine, I think.
    • The <details> element be be expanded & navigated via keyboard.
    • Voiceover seems OK.

Status

LGTM 👍

@goplayoutside3 goplayoutside3 merged commit 756ee7e into master Nov 13, 2024
5 checks passed
@goplayoutside3 goplayoutside3 deleted the temp-notice-banner branch November 13, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants