Update package.json to use node 20+ #7207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2024
goplayoutside3
approved these changes
Nov 1, 2024
shaunanoordin
force-pushed
the
package-json-engines-node-20
branch
from
089c6f9 to
7349179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR modifies our package.json to specify that PFE's supposed to run with node 20+, and npm 10+.
This update was spurred by the stylus dependabot bump, as stylus 8.0.0 has a breaking change that requires node 18.12.0. In practice this isn't a problem as all our deploy & Docker files use Node.js 20, but in theory it could be a problem for local devs who think that PFE should work with, say, Node 18.0.0.
Status
Looking for comment, ready for review, but low priority, to be honest.