Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stylus-loader from 7.1.3 to 8.1.1 #7183

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 19, 2024

Bumps stylus-loader from 7.1.3 to 8.1.1.

Release notes

Sourced from stylus-loader's releases.

v8.1.1

8.1.1 (2024-09-18)

Bug Fixes

  • avoid losing use during incremental build (#425) (4f28957)

v8.1.0

8.1.0 (2024-01-30)

Features

  • add @​rspack/core as an optional peer dependency (#407) (4315ff6)

v8.0.0

8.0.0 (2024-01-15)

⚠ BREAKING CHANGES

  • minimum supported Node.js version is 18.12.0 (#404) (505ecd0)
Changelog

Sourced from stylus-loader's changelog.

8.1.1 (2024-09-18)

Bug Fixes

  • avoid losing use during incremental build (#425) (4f28957)

8.1.0 (2024-01-30)

Features

  • add @​rspack/core as an optional peer dependency (#407) (4315ff6)

8.0.0 (2024-01-15)

⚠ BREAKING CHANGES

  • minimum supported Node.js version is 18.12.0 (#404) (505ecd0)
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies javascript Pull requests that update Javascript code labels Sep 19, 2024
@coveralls
Copy link

coveralls commented Sep 19, 2024

Coverage Status

coverage: 56.684% (+0.004%) from 56.68%
when pulling 27a34cc on dependabot/npm_and_yarn/stylus-loader-8.1.1
into 6baeeaf on master.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/stylus-loader-8.1.1 branch 2 times, most recently from 89bcd26 to 7fcd469 Compare October 17, 2024 15:46
@shaunanoordin
Copy link
Member

Hmm. This one has a potentially breaking change, as stylus-loader 8.0.0 requires Node.js 18.12.0

  • As of PFE commit f506e90, our package.json only asks for engines.node >= 18, so this theoretically opens .
  • However, our deploy_production.yml (and staging, and branch, etc) uses Node lts/iron (aka Node 20), and our Dockerfile uses Node 20, so in practice this shouldn't be a problem.

I imagine the most straightforward solution is to increase the engines.node value in our package.json, so I'll open up a PR for that.

I'll continue reviewing this dependabot bump now.

@shaunanoordin
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/stylus-loader-8.1.1 branch from 7fcd469 to 00b431f Compare October 31, 2024 18:44
@shaunanoordin
Copy link
Member

Wait, something's wrong. While testing locally, I'm seeing a blank page on local.zooniverse.org:3735

However, the error on the console is

Uncaught TypeError: _browser.BrowserTracing is not a constructor
    at initSentry (init-sentry.js:11:1)
    at ./app/main.cjsx (main.cjsx:48:1)
    at __webpack_require__ (bootstrap:22:1)
    at startup:6:1
    at startup:6:1

which makes me think the problem's coming from the recently-merged #7206 .

One second while I run tests.

@shaunanoordin
Copy link
Member

Yup, it's 7206. Reverting that now.

@shaunanoordin
Copy link
Member

@dependabot rebase

Bumps [stylus-loader](https://github.com/webpack-contrib/stylus-loader) from 7.1.3 to 8.1.1.
- [Release notes](https://github.com/webpack-contrib/stylus-loader/releases)
- [Changelog](https://github.com/webpack-contrib/stylus-loader/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/stylus-loader@v7.1.3...v8.1.1)

---
updated-dependencies:
- dependency-name: stylus-loader
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/stylus-loader-8.1.1 branch from 00b431f to 27a34cc Compare October 31, 2024 19:36
Copy link
Member

@shaunanoordin shaunanoordin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - after the fiasco with #7206, (reverted in #7209,) I actually ran a local test to see if PFE compiles. It does, so this PR gets a pass.

Please see #7207 for the related package.json update.

@shaunanoordin shaunanoordin merged commit 5fde083 into master Oct 31, 2024
5 checks passed
@shaunanoordin shaunanoordin deleted the dependabot/npm_and_yarn/stylus-loader-8.1.1 branch October 31, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants