-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter history #253
Filter history #253
Conversation
The solution proposed here requires requering. Issue zonemaster/zonemaster-backend#830 suggests a solution that lets GUI get information on which test is delegated and which is undelegated when receiving the full list. That could make it possible to tag the full list to give more information to the users. @blacksponge, what do you think? |
I think it would be more reasonable to show delegated only by default. By running a undelegated test you can always create both total failure and total success. Secondly, I think it would be valuable to see which are delegated and which are not when all are listed (requires zonemaster/zonemaster-backend#830 to be resolved). Thirdly, even though the three-way selection (delegated, undelegated, all) it would give a simple interface to only have default (delegated) and "also show undelegated tests". Else, it works as expected. |
I don't think that is much of an issue but I can wait for the other issue to be resolved. (I can even make that happen)
I fully agree with you. I was also thinking that maybe it can be valuable to also show that information on the result page (maybe related to #232)
I can do that, sure.
I am not so sure, I do find it valuable to only list undelegated tests, when we want to compare with a previous similar test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works fine! Please just add support for singular and plural, respectively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have 8 tests on iis.se in the database, but the GUI only shows the four oldest tests.
(I had not restarted the GUI enough.)
Testing v2021.2lgtm |
Purpose
Add filter usage in history component.
Context
Changes
Add "buttons" to filter the tests list. This uses the "filter" parameter of the API, now that it is correctly working.
How to test this PR
Load a result and verify if you can filter the test list correctly.