Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to filter tests in history #251

Closed
hannaeko opened this issue Jul 20, 2021 · 3 comments · Fixed by #253
Closed

Ability to filter tests in history #251

hannaeko opened this issue Jul 20, 2021 · 3 comments · Fixed by #253
Assignees
@hannaeko
Labels
T-Feature Type: New feature in software or test case description
Milestone
v2021.2

Comments

@hannaeko
Copy link
Member

Now that the backend is going to correctly support delegated / undelegated filter for history, the GUI could implements the use of those filters in the history component.

From the discussion in zonemaster/zonemaster-backend#826 (comment) :

  • In the normal case, the undelegated tests are unwanted because the are really not comparable with any other test unless the domain name and DS settings are equal.
  • By default only delegated tests are to be shown, with a buttons saying "all historic tests" and "only undelegated tests".
@hannaeko hannaeko added the T-Feature Type: New feature in software or test case description label Jul 20, 2021
@hannaeko hannaeko added this to the v2021.2 milestone Jul 20, 2021
@hannaeko hannaeko mentioned this issue Jul 20, 2021
Merged
@matsduf
Copy link
Contributor

matsduf commented Jul 20, 2021

I think this will improve the user experience of the GUI.

This was referenced Jul 21, 2021
Closed
Closed
@matsduf
Copy link
Contributor

matsduf commented Jul 21, 2021

zonemaster/zonemaster-backend#830 suggests an update so that the value is of "undelegated" is included if requested.

@hannaeko hannaeko self-assigned this Jul 28, 2021
@hannaeko hannaeko mentioned this issue Jul 28, 2021
Merged
@hannaeko hannaeko linked a pull request Aug 4, 2021 that will close this issue
Filter history #253
Merged
@ghost
Copy link

ghost commented Nov 25, 2021

Done with #253

@ghost ghost closed this as completed Nov 25, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hannaeko hannaeko

Labels
T-Feature Type: New feature in software or test case description
Projects
None yet
Milestone
v2021.2
Development

Successfully merging a pull request may close this issue.

Filter history hannaeko/zonemaster-gui
2 participants
@matsduf @hannaeko