Address PR comments [5]
GitGuardian / GitGuardian Security Checks
failed
Nov 22, 2024 in 0s
3 secrets uncovered!
3 secrets were uncovered from the scan of 36 commits in your pull request. ❌
Please have a look to GitGuardian findings and remediate in order to secure your code.
Details
🔎 Detected hardcoded secrets in your pull request
- Pull request #3170:
feat/zetaclient/tss-improvements👉develop
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 14567965 | Triggered | Generic Password | c5b10c6 | cmd/zetaclientd/start.go | View secret |
| 14567965 | Triggered | Generic Password | ade21aa | cmd/zetaclientd/start.go | View secret |
| 14567965 | Triggered | Generic Password | c5b10c6 | cmd/zetaclientd/start.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Loading