Address PR comments [5]

zeta-chain · Nov 22, 2024 · 9b264d9 · 9b264d9
1 parent 578bf5e
commit 9b264d9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/pkg/cosmos/cosmos.go b/pkg/cosmos/cosmos.go
@@ -4,8 +4,9 @@ import (
 	"github.com/cosmos/cosmos-sdk/types/bech32/legacybech32" // nolint
 )
 
+const Bech32PubKeyTypeAccPub = legacybech32.AccPK
+
 var (
-	GetPubKeyFromBech32    = legacybech32.UnmarshalPubKey
-	Bech32ifyPubKey        = legacybech32.MarshalPubKey
-	Bech32PubKeyTypeAccPub = legacybech32.AccPK
+	GetPubKeyFromBech32 = legacybech32.UnmarshalPubKey
+	Bech32ifyPubKey     = legacybech32.MarshalPubKey
 )
diff --git a/zetaclient/tss/crypto.go b/zetaclient/tss/crypto.go
@@ -104,10 +104,8 @@ func (k PubKey) Bytes(compress bool) []byte {
 // Example: `zetapub1addwnpepq2fdhcmfyv07s86djjca835l4f2n2ta0c7le6vnl508mseca2s9g6slj0gm`
 func (k PubKey) Bech32String() string {
 	v, err := cosmos.Bech32ifyPubKey(cosmos.Bech32PubKeyTypeAccPub, k.cosmosPubKey)
-
-	// should not happen as we only set k.cosmosPubKey from the constructor
 	if err != nil {
-		panic("PubKey.Bech32String: " + err.Error())
+		return "" // not possible
 	}
 
 	return v