Refactor EndpointInfo in C# #3185
Conversation
| /// <returns>True if the endpoint is secure.</returns> | ||
| public abstract bool secure(); | ||
| /// <remarks>The type of an underlying endpoint is always the same as the type its enclosing endpoint.</remarks> | ||
| public virtual short type() => underlying?.type() ?? -1; |
There was a problem hiding this comment.
Should we instead assert underlying is not null?
There was a problem hiding this comment.
Even with a Debug.Assert, we would still need to return something. So I think -1 is fine here.
| info.timeout = info.underlying.timeout; | ||
| return info; | ||
| } | ||
| public override EndpointInfo getInfo() => new WSEndpointInfo(_delegate.getInfo(), _resource); |
There was a problem hiding this comment.
It's not clear to me how the secure, type, datagram, timeout, compress fields of this returned WSEndpointInfo are set.
They should be set to the underlying endpoint info values.
There was a problem hiding this comment.
I think it works similar to how it did before, the difference is that type(), secure(), .. are called once when constructed.
There was a problem hiding this comment.
See the base class, Ice.EndpointInfo.
type(), datagram() and secure() delegate to underlying, while the timeout and compress fields are set in the constructor from underlying.
This PR simplifies EndpointInfo in C#, in particular, make all the fields readonly.