Refactor EndpointInfo and ConnectionInfo in C++ #3191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
approved these changes
Nov 26, 2024
| } | ||
|
|
||
| return info; | ||
| return make_shared<Ice::SSL::ConnectionInfo>( |
There was a problem hiding this comment.
A minor issue with this update, and other certificates. If the constructor throws, or _delegate->getInfo() throws. we leak the peerCertificate.
There was a problem hiding this comment.
It's not clear to me why the constructor or _delegate->getInfo would throw.
Small issue in the MATLAB code, now fixed. A more interesting issue was the failure on macos release, apparently due to weak vtables. Also fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the C++ equivalent of #3185 and #3187.