build: wifi: allow espressif boards to test net/wifi use cases #80785

sylvioalves · 2024-11-03T00:15:45Z

This aims to allow Espressif boards to test Wi-Fi drivers without binary blobs. The following changes were added:

Convert NRF_WIFI_BUILD_ONLY_MODE and NXP_WIFI_BUILD_ONLY_MODE to use the same common Kconfig name WIFI_BUILD_ONLY_MODE.
Modify hal_nxp and hal_espressif to support the above change. Include espressif Wi-Fi RF stubs.
Modify all esp32-based boards.yml to allow net tests.

zephyrbot · 2024-11-03T00:16:41Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_espressif	zephyrproject-rtos/hal_espressif@`980d61c`	zephyrproject-rtos/hal_espressif#374	zephyrproject-rtos/hal_espressif#374/files
hal_nxp	zephyrproject-rtos/hal_nxp@`c42d70d` (`master`)	zephyrproject-rtos/hal_nxp#457	zephyrproject-rtos/hal_nxp#457/files

⛔ DNM label due to: 2 projects with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

sylvioalves · 2024-11-03T02:20:04Z

@krish2718 @dleach02 As you can see in this PR (commit bd260a9), I have aimed to consolidate the WIFI_BUILD_ONLY_MODE as common Kconfig. I have also submitted a similar approach to BT driver as you can see in #80786.

Please, let me know your thoughts about both. I think that we could rename XXX_BUILD_ONLY_MODE to something more clear as such as XXX_BUILD_WITH_NO_BLOBS or similar.

Are you OK making this WIFI symbol global as in this PR?
Does it sound good renaming it?
We could create a global symbol to be used for both Wi-Fi and BT instead of splitting in 2. Any thoughts? Could be something like CONFIG_BUILD_WITH_NO_BLOBS.

@carlescufi PTAL.

jukkar

One of the commit messages says:

This lets esp32-based boards to be tested regarding
Wi-Fi changes. WIP

About the WIP, wondering now that is there more to come to that commit or in some subsequent commits, or was it just a left over from some earlier work?

sylvioalves · 2024-11-28T09:06:11Z

One of the commit messages says:
This lets esp32-based boards to be tested regarding
Wi-Fi changes. WIP
About the WIP, wondering now that is there more to come to that commit or in some subsequent commits, or was it just a left over from some earlier work?

@jukkar, sorry, it is left over, will update again. Do you mind if I do so once hal_nxp is synced? Then I submit another Pr updating both entries.

sylvioalves · 2024-11-30T17:58:09Z

@dleach02 As you requested, pinging you so we can continue with hal_nxp.

sylvioalves · 2024-11-30T19:02:49Z

@krish2718 @jhedberg @jukkar as you can see in this PR and at #80786, we could end up having 2 different Kconfig to enable CI build without blobs (for Wi-Fi and BT). We could convert both to a single Kconfig entry as discussed in previous comments, i.e., CONFIG_BUILD_ONLY_NO_BLOBS. Let me know if you are ok with it and I shall update the PRs accordingly.

krish2718 · 2024-11-30T19:10:02Z

Agreed, this should be a common option for builds that use blobs.

jhedberg · 2024-11-30T19:37:14Z

@sylvioalves Thanks for taking this initiative! It sounds like a quite useful feature, and something we'll certainly want to support for Silabs as well. The single generic Kconfig option seems like the best approach to me.

Convert vendor specific **_WIFI_BUILD_ONLY_MODE symbol as global in order to provide common build flag to enable CI with no blobs. Signed-off-by: Sylvio Alves <[email protected]>

Add stubs to allow building Wi-Fi interface without binary blobs. Only for CI tests. Update ESP32 Wi-Fi kconfig entry accordingly. Signed-off-by: Sylvio Alves <[email protected]>

Allow espressif platform to be properly tested in CI. Signed-off-by: Sylvio Alves <[email protected]>

This lets esp32-based boards to be tested regarding Wi-Fi changes. Signed-off-by: Sylvio Alves <[email protected]>

sylvioalves · 2024-12-02T12:37:07Z

PR was updated with the common CONFIG_BUILD_ONLY_NO_BLOBS. Will merge hal side when we get proper approvals here. Thanks.

jhedberg · 2024-12-02T13:06:49Z

drivers/wifi/Kconfig

@@ -35,6 +35,13 @@ config WIFI_USE_NATIVE_NETWORKING
 	  When selected, this hidden configuration enables Wi-Fi driver
 	  to use native ethernet stack interface.

+config BUILD_ONLY_NO_BLOBS


I guess drivers/wifi/Kconfig is the wrong place for this, now that it's completely generic. Perhaps modules/Kconfig instead?

Btw, while I know I suggested the option name, I'm a little bit hesitant about it, since it's easily read as "Build only <something>", i.e. only "something" should be built, which is different from the actual meaning. Alternatives that come to mind are BUILD_WITHOUT_BLOBS, BLOB_STUBS, or NO_BLOBS. (sorry for adding extra hassle with this, but I think it's better to get the name right from the beginning rather than having to fix it when something has already been merged). I also don't have a super strong opinion here, i.e. if others think that BUILD_ONLY_NO_BLOBS is clear enough, then I won't object :)

Of course, I need to move it out of wifi section.
My initial suggestion as described in this PR was CONFIG_BUILD_WITH_NO_BLOBS. Sounds CONFIG_BUILD_WITHOUT_BLOBS is even better. Are you ok with it? I can rename it again and wait for feedbacks.

BUILD_WITHOUT_BLOBS is fine

BUILD_WITHOUT_BLOBS is fine, ONLY was added to imply that this is build-only and cannot be used on a real board for testing.

BUILD_WITHOUT_BLOBS is fine, ONLY was added to imply that this is build-only and cannot be used on a real board for testing.

Yeah, that was my idea when I proposed it, but then I realized that when you try to read it as normal English it's mildly confusing. Either way is fine with me.

Also, as long as we output a clear warning during build, I think that should do the job of informing the user that the result is something non-functional.

Considering the commments above, I would keep as is: BUILD_ONLY_NO_BLOBS.
There is a big warning banner during build that states that it is not for real-world operation, but, BUILD_WITHOUT_BLOBS leaves a bit of margin to bad interpretation as it sounds to "work" without blobs.

sylvioalves force-pushed the enh/make_wifi_build_only_global branch from 264b271 to e00ed56 Compare November 3, 2024 00:16

zephyrbot added manifest manifest-hal_espressif manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Nov 3, 2024

sylvioalves force-pushed the enh/make_wifi_build_only_global branch 3 times, most recently from 42bd0e8 to 95b4643 Compare November 3, 2024 00:33

sylvioalves marked this pull request as ready for review November 3, 2024 02:21

zephyrbot added area: Wi-Fi Wi-Fi area: Networking labels Nov 3, 2024

sylvioalves mentioned this pull request Nov 3, 2024

driver: bt: add BT_BUILD_ONLY_MODE to allow CI tests #80786

Draft

zephyrbot added area: Samples Samples area: Sockets Networking sockets platform: NXP Drivers NXP Semiconductors, drivers platform: ESP32 Espressif ESP32 labels Nov 3, 2024

zephyrbot requested review from jukkar, kartben, Kludentwo, krish2718, LucasTambor, marekmatej, nashif, pdgendt, raffarost, rlubos, sachinthegreen and ssharks November 3, 2024 02:22

sylvioalves force-pushed the enh/make_wifi_build_only_global branch from 5e2a900 to 87d1301 Compare November 28, 2024 02:05

kartben previously approved these changes Nov 28, 2024

View reviewed changes

jukkar reviewed Nov 28, 2024

View reviewed changes

wmrsouza previously approved these changes Nov 28, 2024

View reviewed changes

sylvioalves force-pushed the enh/make_wifi_build_only_global branch from 87d1301 to 9885ece Compare November 28, 2024 12:21

jukkar previously approved these changes Nov 30, 2024

View reviewed changes

sylvioalves mentioned this pull request Nov 30, 2024

drivers: bluetooth: add stubs to allow CI testing without blobs zephyrproject-rtos/hal_espressif#359

Open

sylvioalves dismissed stale reviews from jukkar, kartben, and wmrsouza via c406f38 December 2, 2024 11:23

sylvioalves force-pushed the enh/make_wifi_build_only_global branch from 9885ece to c406f38 Compare December 2, 2024 11:23

sylvioalves added 4 commits December 2, 2024 09:05

drivers: wifi: make WIFI_BUILD_ONLY_MODE global symbol

9df96c5

Convert vendor specific **_WIFI_BUILD_ONLY_MODE symbol as global in order to provide common build flag to enable CI with no blobs. Signed-off-by: Sylvio Alves <[email protected]>

west.yml: espressif: add wifi stubs

0b588f9

Add stubs to allow building Wi-Fi interface without binary blobs. Only for CI tests. Update ESP32 Wi-Fi kconfig entry accordingly. Signed-off-by: Sylvio Alves <[email protected]>

samples: net: wifi: add esp32 platform

801802b

Allow espressif platform to be properly tested in CI. Signed-off-by: Sylvio Alves <[email protected]>

boards: esp32-based: remove net from ignore list

269d00b

This lets esp32-based boards to be tested regarding Wi-Fi changes. Signed-off-by: Sylvio Alves <[email protected]>

sylvioalves force-pushed the enh/make_wifi_build_only_global branch from c406f38 to 269d00b Compare December 2, 2024 12:06

sylvioalves requested review from jukkar and kartben December 2, 2024 12:36

krish2718 approved these changes Dec 2, 2024

View reviewed changes

jhedberg requested changes Dec 2, 2024

View reviewed changes

kartben assigned jukkar and unassigned kartben Dec 2, 2024

jukkar approved these changes Dec 2, 2024

View reviewed changes

wmrsouza approved these changes Dec 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: wifi: allow espressif boards to test net/wifi use cases #80785

build: wifi: allow espressif boards to test net/wifi use cases #80785

sylvioalves commented Nov 3, 2024

zephyrbot commented Nov 3, 2024 •

edited

Loading

sylvioalves commented Nov 3, 2024 •

edited

Loading

jukkar left a comment

sylvioalves commented Nov 28, 2024 •

edited

Loading

sylvioalves commented Nov 30, 2024 •

edited

Loading

sylvioalves commented Nov 30, 2024

krish2718 commented Nov 30, 2024

jhedberg commented Nov 30, 2024

sylvioalves commented Dec 2, 2024

jhedberg Dec 2, 2024

jhedberg Dec 2, 2024 •

edited

Loading

sylvioalves Dec 2, 2024 •

edited

Loading

jhedberg Dec 2, 2024

krish2718 Dec 2, 2024

jhedberg Dec 2, 2024

jhedberg Dec 2, 2024

sylvioalves Dec 2, 2024

build: wifi: allow espressif boards to test net/wifi use cases #80785

Are you sure you want to change the base?

build: wifi: allow espressif boards to test net/wifi use cases #80785

Conversation

sylvioalves commented Nov 3, 2024

zephyrbot commented Nov 3, 2024 • edited Loading

sylvioalves commented Nov 3, 2024 • edited Loading

jukkar left a comment

Choose a reason for hiding this comment

sylvioalves commented Nov 28, 2024 • edited Loading

sylvioalves commented Nov 30, 2024 • edited Loading

sylvioalves commented Nov 30, 2024

krish2718 commented Nov 30, 2024

jhedberg commented Nov 30, 2024

sylvioalves commented Dec 2, 2024

jhedberg Dec 2, 2024

Choose a reason for hiding this comment

jhedberg Dec 2, 2024 • edited Loading

Choose a reason for hiding this comment

sylvioalves Dec 2, 2024 • edited Loading

Choose a reason for hiding this comment

jhedberg Dec 2, 2024

Choose a reason for hiding this comment

krish2718 Dec 2, 2024

Choose a reason for hiding this comment

jhedberg Dec 2, 2024

Choose a reason for hiding this comment

jhedberg Dec 2, 2024

Choose a reason for hiding this comment

sylvioalves Dec 2, 2024

Choose a reason for hiding this comment

zephyrbot commented Nov 3, 2024 •

edited

Loading

sylvioalves commented Nov 3, 2024 •

edited

Loading

sylvioalves commented Nov 28, 2024 •

edited

Loading

sylvioalves commented Nov 30, 2024 •

edited

Loading

jhedberg Dec 2, 2024 •

edited

Loading

sylvioalves Dec 2, 2024 •

edited

Loading