drivers: bluetooth: add stubs to allow CI testing without blobs #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvioalves
force-pushed
the
enh/bt_build_only_mode
branch
from
2afb823
to
fab21da
Compare
sylvioalves
force-pushed
the
enh/bt_build_only_mode
branch
2 times, most recently
from
16de921
to
75e97a8
Compare
sylvioalves
requested review from
marekmatej,
LucasTambor,
wmrsouza and
raffarost
raffarost
approved these changes
Nov 28, 2024
zephyr/esp32/CMakeLists.txt
Outdated
| -L${CMAKE_CURRENT_SOURCE_DIR}/../blobs/lib/esp32 | ||
| ) | ||
|
|
||
| if (NOT(CONFIG_WIFI_BUILD_ONLY_MODE OR CONFIG_BT_BUILD_ONLY_MODE)) |
There was a problem hiding this comment.
should it be AND instead of OR?
if only one is in build mode, the lib should be included as well
There was a problem hiding this comment.
Or perhaps use only one Kconfig for both cases, such as CONFIG_RF_BUILD_ONLY_MODE
There was a problem hiding this comment.
Or even more generic, for any feature that may depend on blobs, that that seems like the ultimate purpose that this is being introduced. E.g. something like CONFIG_BUILD_ONLY_NO_BLOBS.
There was a problem hiding this comment.
@jhedberg please read my previous comment at zephyrproject-rtos/zephyr#80785 (comment)
wmrsouza
approved these changes
Nov 29, 2024
Update BT driver and add necessary stubs so that CI can run without binay blobs. Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves
force-pushed
the
enh/bt_build_only_mode
branch
from
75e97a8
to
9b2197c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all bluetooth stubs in order to allow building without blobs.