soc: arm: nxp_s32: s32k1: improve code cache init #66161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
bperseghetti,
danieldegrasse,
Dat-NguyenDuy,
dbaluta,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
iuliana-prodan,
mmahadevan108,
PetervdPerk-NXP and
yvanderv
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nxp
DNM
dleach02
previously approved these changes
Dec 5, 2023
iuliana-prodan
previously approved these changes
Dec 5, 2023
bperseghetti
previously approved these changes
Dec 7, 2023
Currently Code Cache cannot be enabled because its initialization is guarded by Kconfig options which depend on CPU core cache support, but S32K14x devices has a SoC specific L1 cache controller. Hence, introduce a SoC-specific symbol to enable Code Cache. Note that the cache controller is not available for S32K11x devices. Signed-off-by: Manuel Argüelles <[email protected]>
Use the HAL cache driver to initialize the Code Cache. Signed-off-by: Manuel Argüelles <[email protected]>
manuargue
dismissed stale reviews from bperseghetti, iuliana-prodan, and dleach02
via
c6c2bc3
Dat-NguyenDuy
approved these changes
Dec 7, 2023
henrikbrixandersen
requested review from
iuliana-prodan,
dleach02 and
bperseghetti
henrikbrixandersen
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up for the changes just merged as a hotfix in #66148.
Currently, Code Cache cannot be enabled because its initialization is guarded by Kconfig options which depend on CPU core caches and this is not the case for S32K1xx devices. Hence, introduce a SoC-specific Kconfig option, selected by default, to enable it.
Additionally, use the HAL cache driver to initialize the Code Cache.