Update board and SoC linker script handling #64544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejlmand
requested review from
nashif,
parthitce,
julius-barendt,
dcpleung,
andyross,
soburi,
henrikbrixandersen,
dleach02,
kgugala,
pgielda,
aescolar,
daor-oti,
lorc,
carlocaione,
povergoing,
firscity,
aaillet,
stephanosio,
ibirnbaum,
Mani-Sadhasivam,
vanti,
arnopo,
erwango,
yonsch,
fkokosinski,
ssekar15,
MulinChao,
ChiHuaL,
anangl and
manuargue
as code owners
tejlmand
force-pushed
the
cmake_soc_linker_script_handling
branch
from
3da5c6e to
ad197ff
Compare
This commit updates all riscv SoCs to set SOC_LINKER_SCRIPT CMake variable to point to active linker script directly. Signed-off-by: Torsten Rasmussen <[email protected]>
This commit updates all sparc SoCs to set SOC_LINKER_SCRIPT CMake variable to point to active linker script directly. Signed-off-by: Torsten Rasmussen <[email protected]>
This commit updates all xtensa SoCs to set SOC_LINKER_SCRIPT CMake variable to point to active linker script directly. Signed-off-by: Torsten Rasmussen <[email protected]>
This commit updates all x86 SoCs to set SOC_LINKER_SCRIPT CMake variable to point to active linker script directly. Signed-off-by: Torsten Rasmussen <[email protected]>
Update the ip_k66f board to use BOARD_LINKER_SCRIPT variable. Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand
force-pushed
the
cmake_soc_linker_script_handling
branch
from
ad197ff to
f5836a0
Compare
nordicjm
requested review from
povergoing,
ruuddw,
carlescufi,
aescolar and
ifyall
carlescufi
approved these changes
Nov 2, 2023
|
@ifyall @povergoing @fabiobaltieri @fkokosinski @ruuddw can you please take a look? |
aescolar
approved these changes
Nov 2, 2023
povergoing
approved these changes
Nov 2, 2023
fabiobaltieri
approved these changes
Nov 2, 2023
andyross
reviewed
Nov 2, 2023
ruuddw
approved these changes
Nov 3, 2023
jhedberg
approved these changes
Nov 3, 2023
3 tasks
golowanow
added a commit
to golowanow/zephyr
that referenced
this pull request
Nov 3, 2023
Fix build issue with linker.id depreciated for arduino_uno_r4_minima platform and observed on samples/synchronization/sample.kernel.synchronization after zephyrproject-rtos#64544. Signed-off-by: Dmitrii Golovanov <[email protected]>
golowanow
added a commit
to golowanow/zephyr
that referenced
this pull request
Nov 3, 2023
Fix build issue with linker.id depreciated for arduino_uno_r4_minima platform and observed on samples/synchronization/sample.kernel.synchronization after zephyrproject-rtos#64544. Signed-off-by: Dmitrii Golovanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleanup and updates the handling of board and SoC linker scripts.
Several SoCs creates a linker.ld file which sole purpose is to include
another arch common linker script, often with content like this:
instead of 100+ SoC specific linker.ld files containing just a single
include line of above structure, then this commit introduces two new
CMake variables, BOARD_LINKER_SCRIPT and SOC_LINKER_SCRIPT.
This allows the board and SoC CMake code to point directly to a common
linker script instead of creating a dummy linker.ld file doing this.
With this PR, 144 dummy
linker.ldare removed and replaced with a single CMake line settingSOC_LINKER_SCRIPT.The first commit provides the new variables, and then a commit for each
soc/<arch>update.