-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soc: arm: Fix linker.ld depreciation warning for arduino_uno_r4_minima #64789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golowanow
requested review from
MaureenHelm,
galak and
ioannisg
as code owners
November 3, 2023 15:32
golowanow
changed the title
soc: arm: Fix build issue for arduino_uno_r4_minima
soc: arm: Fix linker.ld build issue for arduino_uno_r4_minima
Nov 3, 2023
golowanow
added
Hotfix
Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.
Trivial
Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
labels
Nov 3, 2023
this is already fixed #64781 |
golowanow
removed
the
Hotfix
Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.
label
Nov 3, 2023
golowanow
force-pushed
the
fix_2023110302
branch
from
November 3, 2023 17:22
fe936d7
to
dd41f9b
Compare
right, I see it is fixed for cmake path error, and this fix is now just to resolve cmake depreciation warning on pre-defined linker.ld for this particular board. |
golowanow
force-pushed
the
fix_2023110302
branch
from
November 3, 2023 18:02
dd41f9b
to
564d332
Compare
golowanow
changed the title
soc: arm: Fix linker.ld build issue for arduino_uno_r4_minima
soc: arm: Fix linker.ld depreciation warning for arduino_uno_r4_minima
Nov 3, 2023
soburi
reviewed
Nov 3, 2023
Thank you for notifying me. |
Fix cmake depreciation warning on pre-defined linker.id (soc/arm/renesas_ra/ra4m1/linker.ld) used for arduino_uno_r4_minima. Signed-off-by: Dmitrii Golovanov <[email protected]>
golowanow
force-pushed
the
fix_2023110302
branch
from
November 4, 2023 07:00
564d332
to
2d2bad5
Compare
soburi
approved these changes
Nov 4, 2023
nashif
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Build System
Trivial
Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cmake depreciation warning on pre-defined linker.id (soc/arm/renesas_ra/ra4m1/linker.ld) used for arduino_uno_r4_minima.
Fix build issue with linker.ld depreciated for arduino_uno_r4_minima platform and observed onsamples/synchronization/sample.kernel.synchronization after #64544.
see CI build failure -
https://github.com/zephyrproject-rtos/zephyr/actions/runs/6746158923/job/18339718127?pr=64783