metrics: Added the metrics module from legacy #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashlamba
changed the title
yashlamba
force-pushed
the
metrics-module
branch
from
6f2ba58 to
fa8b1e3
Compare
yashlamba
commented
Sep 14, 2023
slint
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Some minor comments, but otherwise looks good!
Regarding commit message style, try to keep a single component in the message, also for brevity, i.e.
-site: zenodo_rdm: metrics: imported metrics module from zenodo/zenodo
+metrics: imported metrics module from zenodo/zenodoSometimes if we have "sub-components" we use dashes, e.g. deposit-ui: fixed validation error display.
yashlamba
force-pushed
the
metrics-module
branch
from
3672327 to
7e9ef4c
Compare
|
Hey @slint, thanks for the review. Before we merge this, we should add + test the Uptime bot secrets required as well. |
alejandromumo
pushed a commit
to alejandromumo/zenodo-rdm
that referenced
this pull request
Jul 16, 2024
* Imported metrics module from zenodo/zenodo * Updated license and copyright information * Updated module for zenodoRDM * Update download volume aggregation index * `.format(...) -> f-strings` * Move and rename config vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved: https://github.com/zenodo/zenodo/tree/master/zenodo/modules/metrics from Zenodo -> ZenodoRDM
Quite a few indices for opensearch and fields have been updated.
Closes https://github.com/zenodo/rdm-project/issues/60