Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: update configuration for the different environments #524

Closed
slint opened this issue Sep 20, 2023 · 2 comments · Fixed by #542, inveniosoftware/invenio-app-rdm#2451 or inveniosoftware/helm-invenio#77

Comments

@slint
Copy link
Member

slint commented Sep 20, 2023

We currently have a bit of a mix/conflict between configuration sources:

Given that multiple new features require specialized secrets/config (#500, #522, OpenAIRE direct indexing), we should take the chance to reconcile all these config sources.

Some important notes:

  • Application config (available even in local development) should be only in invenio.cfg (or even in upstream modules if it makes sense IvnenioRDM-wide). One such example is the GITHUB_WEBHOOK_RECEIVER_ID = 'gtihub' (we would never use a different value in dev/prod/QA).
  • Ideally, we should always aim at using helm upgrade (or similar) to apply any configuration changes to the deployed environments
  • Synchronize with @psaiz as well for changes to the GitLab repo, since there is some ongoing parallel work on OpenShift infra at the moment
@alejandromumo
Copy link
Member

alejandromumo commented Sep 25, 2023

Moved or removed configs from OpenShift

I've found that the following configs could be removed from openshift:

  • GITHUB_WEBHOOK_RECEIVER_ID (removed from zenodo-rdm-openshift, it's added by the module and should work)
  • GITHUB_INTEGRATION_ENABLED (removed from zenodo-rdm-openshift, already exists in zenodo_rdm/invenio.cfg)
  • DATACITE_ENABLED (removed from zenodo-rdm-openshift, already exists in zenodo_rdm/invenio.cfg)
  • DATACITE_PREFIX (removed from zenodo-rdm-openshift, already exists in zenodo_rdm/invenio.cfg)
  • GITHUB_RELEASE_CLASS (removed from openshift, already in invenio.cfg and added a default in invenio-app-rdm)
  • MAIL_DEFAULT_SENDER (removed from openshift, moved to invenio.cfg)

Added configs

  • OPENAIRE_API_CREDENTIALS
  • logstash configs

@alejandromumo
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants