Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker workflow: add pre-build step #57

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Conversation

cosimomeli
Copy link
Contributor

Description

Add pre-build step in docker workflow to run the ci-pre-build task from Makefile, if the file exists.
This, as example, enables Go builds without vendor folder to download private dependencies before the docker build.

Changes Made

Add pre-build step in docker workflow

Related Issues

N/A

Checklist

  • I have used a PR title that is descriptive enough for a release note.
  • I have tested these changes locally.
  • I have added appropriate tests or updated existing tests.
  • I have tested these changes on a dedicated VM or a customer VM [name of the VM]
  • I have added appropriate documentation or updated existing documentation.

@cosimomeli cosimomeli added the feature This issue/PR relates to a feature request. label Oct 10, 2023
@chicco785 chicco785 requested review from a team October 10, 2023 14:00
@cosimomeli cosimomeli changed the title Add pre-build step in docker workflow Add pre-build step in docker workflow Oct 10, 2023
@chicco785 chicco785 changed the title Add pre-build step in docker workflow docker workflow: add pre-build step Oct 10, 2023
@chicco785 chicco785 merged commit a06991c into main Oct 10, 2023
7 checks passed
@chicco785 chicco785 deleted the docker-pre-build-step branch October 10, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants