Skip to content

Commit

Permalink
docker workflow: add pre-build step (#57)
Browse files Browse the repository at this point in the history
## Description

Add pre-build step in docker workflow to run the `ci-pre-build` task
from Makefile, if the file exists.
This, as example, enables Go builds without vendor folder to download
private dependencies before the docker build.

## Changes Made

Add pre-build step in docker workflow

## Related Issues

N/A

## Checklist

- [x] I have used a PR title that is descriptive enough for a release
note.
- [ ] I have tested these changes locally.
- [ ] I have added appropriate tests or updated existing tests.
- [ ] I have tested these changes on a dedicated VM or a customer VM
[name of the VM]
- [x] I have added appropriate documentation or updated existing
documentation.

---------

Co-authored-by: Federico M. Facca <[email protected]>
  • Loading branch information
cosimomeli and chicco785 authored Oct 10, 2023
1 parent ef4adbb commit a06991c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .github/workflows/docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,16 @@ on:
jobs:
build:
runs-on: ubuntu-latest
env:
GH_ACCESS_TOKEN: ${{ secrets.REPO_PRIVATE_READ_PAT }}
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Run pre-build
run: |
if test -f "Makefile"; then
make ci-pre-build
fi
- name: Docker meta
id: meta
uses: docker/metadata-action@v5
Expand Down
1 change: 1 addition & 0 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Features

- docker workflow: add `pre-build` step (PR #57 by @cosimomeli)
- markdown workflow: add optional spell checker (PR #44 by @chicco785)
- add-to-project workflow: add support to assign multiple teams as reviewers
(comma separated without space) (PR #42 by @chicco785)
Expand Down

0 comments on commit a06991c

Please sign in to comment.