Skip to content

Commit

Permalink
golang workflow: add shell configuration to enable pipefail for ben…
Browse files Browse the repository at this point in the history
…chmark job (#56)

## Description

golang workflow: add shell config to enable pipefail for benchmark job

## Changes Made

Add shell config to enable pipefail for benchmark job

## Related Issues

N/A

## Checklist

- [x] I have used a PR title that is descriptive enough for a release
note.
- [ ] I have tested these changes locally.
- [ ] I have added appropriate tests or updated existing tests.
- [ ] I have tested these changes on a dedicated VM or a customer VM
[name of the VM]
- [x] I have added appropriate documentation or updated existing
documentation.

---------

Co-authored-by: chicco785 <[email protected]>
  • Loading branch information
cosimomeli and chicco785 authored Oct 10, 2023
1 parent 09e123c commit ef4adbb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/golang.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ jobs:
with:
go-version-file: go.mod
- name: Run benchmark
shell: bash
run: make ci-bench | tee output.txt
# Download previous benchmark result from cache (if exists)
- name: Download benchmark report from base branch
Expand Down
4 changes: 3 additions & 1 deletion RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Features

- markdown workflow: add optional spell checker (PR #44 by @chicco785)
- add-to-project workflow: add support to assign multiple teams as reviewers
(comma separated without space) (PR #42 by @chicco785)
- Add Docker, Golang and Docker Clean Up workflows (PR #54 by @cosimomeli)
Expand All @@ -13,7 +14,6 @@
to `🔖 Ready` (PR #50 by @chicco785)
- markdown workflow: exclude `vendor` folder from links check (PR #47 by @tejo)
- markdown workflow: exclude `vendor` folder from checks (PR #46 by @tejo)
- markdown workflow: add optional spell checker (PR #44 by @chicco785)
- add-to-project workflow: automatically add reviewers without need of
CODEOWNERS (PR #37 by @chicco785)
- add-to-project workflow: automatically assign pr to its creator (PR #36 by
Expand All @@ -26,6 +26,8 @@

### Bug Fixes

- golang workflow: add shell configuration to enable `pipefail` for benchmark
job (PR #56 by @cosimomeli)
- add-to-project workflow: Fix assignment of reviewers also when PR is still in
draft mode (PR #40 by @chicco785)
- Release-notes workflow: fix default configuration to include only current PR
Expand Down

0 comments on commit ef4adbb

Please sign in to comment.