Limit ingress support to only networking.k8s.io/v1 #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the deprecation of extensions/v1beta1 and networking.k8s.io/v1beta1, remove support for them. Signed-off-by: Katyanna Moura <[email protected]>
Signed-off-by: Katyanna Moura <[email protected]>
|
@katyanna please change the VERSION file to create the next minor version and explain in the readme.md section what the update to >= the new version will do. |
|
I've talked with @mikkeloscar and decided for freezing this for now so other open source users can use the older versions if they need to. |
|
Yeah true I also thought about that and you can change the default in kubernetes-on-aws which we likely already did. |
|
@katyanna I think we can now go on and drop the v1beta1 code |
Signed-off-by: Katyanna Moura <[email protected]>
katyanna
force-pushed
the
ingress-upgrade-v1
branch
from
05ce69b to
a52a239
Compare
* master: Bump github.com/zalando/skipper from 0.17.32 to 0.18.38 (#648) Add test case for rolling in progress stacks Bump github.com/aws/aws-sdk-go from 1.47.0 to 1.49.13 Bump github.com/google/uuid from 1.4.0 to 1.5.0 (#670) Bump github.com/prometheus/client_golang from 1.17.0 to 1.18.0 (#669) Require labels (#666) Bump golang.org/x/crypto from 0.14.0 to 0.17.0
Signed-off-by: Katyanna Moura <[email protected]>
katyanna
force-pushed
the
ingress-upgrade-v1
branch
from
9796906 to
e9794dd
Compare
|
👍 |
We should still change the version to indicate to users that this is no longer supported. |
katyanna
force-pushed
the
ingress-upgrade-v1
branch
from
315a343 to
48272b7
Compare
Signed-off-by: Katyanna Moura <[email protected]>
katyanna
force-pushed
the
ingress-upgrade-v1
branch
from
48272b7 to
d9390b6
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the deprecation of
extensions/v1beta1andnetworking.k8s.io/v1beta1,remove support for them.