Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no default ingressAPIVersion #678

Closed
jhuntwork opened this issue Feb 1, 2024 · 0 comments · Fixed by #679
Closed

There is no default ingressAPIVersion #678

jhuntwork opened this issue Feb 1, 2024 · 0 comments · Fixed by #679

Comments

@jhuntwork
Copy link
Contributor

With #515 the ingressAPIVersion variable is no longer set, because the cli flag was removed which specified a default. This means that when an adapter is created here: https://github.com/zalando-incubator/kube-ingress-aws-controller/blob/master/controller.go#L377 then it is being passed an empty value.

The result we have seen in our systems is this that the requestURI being sent to the kubernetes API is /apis//ingresses which results in a 404. This basically tanks kube-ingress-aws-controller from the beginning.
jhuntwork added a commit to jhuntwork/kube-ingress-aws-controller that referenced this issue Feb 1, 2024
@jhuntwork
Set the default ingress API Version
22c76d5 
Fixes zalando-incubator#678

With the removal of the `--ingress-api-version` flag in 0.15.0, this
value was no longer set and the constructed api URL is incomplete.

Signed-off-by: Jeremy Huntwork <[email protected]>
@jhuntwork jhuntwork mentioned this issue Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set the default ingress API Version jhuntwork/kube-ingress-aws-controller
1 participant
@jhuntwork