Set the default ingress API Version #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes zalando-incubator#678 With the removal of the `--ingress-api-version` flag in 0.15.0, this value was no longer set and the constructed api URL is incomplete. Signed-off-by: Jeremy Huntwork <[email protected]>
|
Thanks, I agree this is a quick mitigation to the issue introduced. Probably it makes sense to not pass it to the adapter at all but just use the constant value inside the adapter. |
|
👍 |
1 similar comment
|
👍 |
|
Thanks for the quick review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #678
With the removal of the
--ingress-api-versionflag in 0.15.0, this value was no longer set and the constructed api URL is incomplete.