Allow specifying the number of range keys in CassandraTransactionalKeyValue workload #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmatican
approved these changes
Jun 20, 2019
| } | ||
|
|
||
|
|
||
| private String getCommasAndRangeKeys() { |
There was a problem hiding this comment.
Nit: add a comment that this returns a string with a , at the start, I almost missed that...
| @@ -162,4 +162,7 @@ | |||
|
|
|||
| // The number of client connections to establish to each host in the YugaByte DB cluster. | |||
| public int concurrentClients = 4; | |||
|
|
|||
| // Number of range keys to include in the primary key. | |||
| public int numRangeKeys = -1; | |||
There was a problem hiding this comment.
any reason to default this to -1 but the static defaults in the app to 0?
ameyb
added a commit
that referenced
this pull request
Aug 6, 2019
ameyb
added a commit
that referenced
this pull request
Aug 6, 2019
…18) * Adding new workload type for Event data timeseries for IoT use-cases * -Added device id, configurable number of devices and event types and Random payload * Updated minor changes for syntax and comments for variables used based on PR review #16 * Updated README and Commandline params * Removed commented variables
|
Was just talking to @rao-vasireddy , that it might be useful to also have a feature for the non-txn workloads, where we can specify the number of non-key columns, to see what the perf implications would be in running a 10 column table vs a 20 column table. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows testing with wide keys.