[expo] improve rendering logic #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** We noticed that #219 introduced the regression of HomeTab rendering and the root cause was the 'rerendering' caused by useHomeTabContext() in HomeTab, which triggered 'unmount' of tabs created by `Tabs.map()` To avoid unmount while rerendering, we need to move the `Tabs.map()` to the fixed list of components instead of an array. Also to ensure sections are properly cached by SectionList, we fixed keyExtractor logic, which can be moved to each `SectionListRender` class so that React can evaluate the key by default instead of having an override `keyExtractor` function in the original SectionList. **Test** - expo **Issue** - N/A
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We noticed that #219 introduced the regression of HomeTab rendering and the root cause was the 'rerendering' caused by useHomeTabContext() in HomeTab, which triggered 'unmount' of tabs created by
Tabs.map()To avoid unmount while rerendering, we need to move the
Tabs.map()to the fixed list of components instead of an array.Also to ensure sections are properly cached by SectionList, we fixed keyExtractor logic, which can be moved to each
SectionListRenderclass so that React can evaluate the key by default instead of having an overridekeyExtractorfunction in the original SectionList.Test
Issue