Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add delete flag #120

Merged
merged 12 commits into from
Nov 3, 2023
Merged

feat: add delete flag #120

merged 12 commits into from
Nov 3, 2023

Conversation

patricktalmeida
Copy link
Contributor

@patricktalmeida patricktalmeida commented Oct 30, 2023

This PR covers discussion on #38.

@patricktalmeida patricktalmeida changed the title Add delete flag feat: add delete flag Oct 31, 2023
@patricktalmeida patricktalmeida marked this pull request as ready for review October 31, 2023 12:03
@yonahd yonahd linked an issue Nov 1, 2023 that may be closed by this pull request
pkg/kor/delete.go Outdated Show resolved Hide resolved
cmd/kor/configmaps.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: 153 lines in your changes are missing coverage. Please review.

Comparison is base (d55b4a9) 52.73% compared to head (5c185ba) 50.11%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   52.73%   50.11%   -2.62%     
==========================================
  Files          18       19       +1     
  Lines        1591     1684      +93     
==========================================
+ Hits          839      844       +5     
- Misses        625      700      +75     
- Partials      127      140      +13     
Files Coverage Δ
pkg/kor/filter_options.go 35.08% <100.00%> (ø)
pkg/kor/kor.go 44.96% <33.33%> (ø)
pkg/kor/multi.go 0.00% <0.00%> (ø)
pkg/kor/exporter.go 5.71% <0.00%> (ø)
pkg/kor/serviceaccounts.go 63.86% <42.85%> (-2.52%) ⬇️
pkg/kor/services.go 60.00% <42.85%> (-6.67%) ⬇️
pkg/kor/confimgmaps.go 66.66% <53.84%> (-2.57%) ⬇️
pkg/kor/deployments.go 54.16% <45.45%> (-5.84%) ⬇️
pkg/kor/hpas.go 49.42% <53.84%> (-2.96%) ⬇️
pkg/kor/ingresses.go 60.21% <53.84%> (-3.12%) ⬇️
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@luisdavim luisdavim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@yonahd yonahd merged commit 5a55f44 into yonahd:main Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discuss: Add Delete Option for Unused Resources
4 participants