Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss: Add Delete Option for Unused Resources #38

Closed
loaynaser3 opened this issue Aug 29, 2023 · 5 comments · Fixed by #120
Closed

Discuss: Add Delete Option for Unused Resources #38

loaynaser3 opened this issue Aug 29, 2023 · 5 comments · Fixed by #120
Labels
enhancement New feature or request

Comments

@loaynaser3
Copy link
Contributor

I'm a new user of Kor, and I'm already impressed with how great of a tool it is! With that said,
I'd like to propose an enhancement or new feature for consideration.

Enhancement Proposal

addition of a --delete option for unused resources in the kor tool.
This enhancement would provide users with the ability to delete resources that are identified as unused.

Expected behavior

The deletion process should be initiated for the unused resources.
The command should provide feedback on the deletion process, indicating which resources are being deleted and their status.

@yonahd
Copy link
Owner

yonahd commented Aug 30, 2023

Hi @loaynaser3
While this would be a great feature, I don't want to put this in the tool.
The main reason is that the tool does not 100% guarantee the resource is unused as you can see here https://github.com/yonahd/kor#supported-resources-and-limitations
And with CRD's we can detect if they are using a resource as well.

If someone wants to use this to delete despite this warning they can import kor and easily get the resources to delete

@yonahd yonahd closed this as completed Aug 30, 2023
@yonahd yonahd added the wontfix This will not be worked on label Aug 30, 2023
@yonahd
Copy link
Owner

yonahd commented Aug 30, 2023

Reopening.
We might implement this with a safe delete

@yonahd yonahd reopened this Aug 30, 2023
@yonahd yonahd removed the wontfix This will not be worked on label Aug 31, 2023
@ozgurcd
Copy link
Contributor

ozgurcd commented Sep 2, 2023

I believe a --dry-run option would be a nice addition at the same time.

@yonahd
Copy link
Owner

yonahd commented Sep 2, 2023

I believe a --dry-run option would be a nice addition at the same time.

Hi @ozgurcd
What do you mean dry run?
Isn't the regular output of the tool a dry run?

Regardless when we put in the delete feature it will be implemented in a safe interactive way

@ozgurcd
Copy link
Contributor

ozgurcd commented Sep 3, 2023

Yeah, you're right.

@yonahd yonahd added the Backlog Not for execution now label Sep 5, 2023
@yonahd yonahd linked a pull request Nov 1, 2023 that will close this issue
@yonahd yonahd added enhancement New feature or request and removed Backlog Not for execution now labels Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants