[Disk Manager] fix delete image idempotency: do not schedule retire base disks if image was not found in database #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
В тестах упал service-kikimr-localdb-compaction-test -- вряд ли связано с этой правкой. |
SvartMetal
reviewed
Nov 18, 2024
gy2411
commented
Nov 25, 2024
gy2411
commented
Nov 25, 2024
gy2411
commented
Nov 25, 2024
cloud/disk_manager/internal/pkg/services/images/create_image_from_disk_task.go
Show resolved
Hide resolved
gy2411
force-pushed
the
users/gayurgin/dm_fix_delete_image_idempotency
branch
from
4f6ec58
to
e2f1b2d
Compare
|
issue на аналогичный рефактиринг для других типов ресурсов #2573 |
SvartMetal
reviewed
Nov 26, 2024
SvartMetal
reviewed
Nov 26, 2024
SvartMetal
approved these changes
Nov 26, 2024
…ase disks if image was not found in database
…image in database; use ImageIDIsNotAcceptedError when create/delete image
…e image; instead return non cancellable error for snapshot/image creation/deletion
…deleteImage methods of resources storage
gy2411
force-pushed
the
users/gayurgin/dm_fix_delete_image_idempotency
branch
from
c409c9e
to
b66e1d7
Compare
BarkovBG
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2438
Fix for the issue.
If imageMeta.size == 0, then the image is already deleted, and there is no reason to schedule retire base disks task.