Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Disk Manager] Refactor code for resource creation/deletion. #2573

Open
gy2411 opened this issue Nov 26, 2024 · 0 comments
Open

[Disk Manager] Refactor code for resource creation/deletion. #2573

gy2411 opened this issue Nov 26, 2024 · 0 comments

Comments

@gy2411
Copy link
Collaborator

gy2411 commented Nov 26, 2024

When we delete resource (disk, snapshot, etc), we use the following pattern. If the resource does not exist in dm database, then we create 'zero' object representing this resource and then proceed as if it was found in database (example for disks). This was needed to delete resources that are not known for disk-manager (for example, snapshots from legacy snapshot storage).

Now this seems to be unnecessary. Here #2497 we get rid of this pattern for snapshots and images. Need to get rid of this for all other types of resources.

Warning! Before refactoring code for some type of resource, make sure that there are no resources of this type that exist for blockstore but don't exist for disk manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant