Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging: basic support #214

Merged
merged 5 commits into from
Nov 21, 2024

Properly handle panics

ac507d4
Select commit
Loading
Failed to load commit list.
Merged

Logging: basic support #214

Properly handle panics
ac507d4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 21, 2024 in 0s

64.28% (-0.17%) compared to bb20e47

View this Pull Request on Codecov

64.28% (-0.17%) compared to bb20e47

Details

Codecov Report

Attention: Patch coverage is 15.38462% with 22 lines in your changes missing coverage. Please review.

Project coverage is 64.28%. Comparing base (bb20e47) to head (ac507d4).

Files with missing lines Patch % Lines
app/server/grpc_metrics.go 11.76% 15 Missing ⚠️
app/server/service_connector.go 33.33% 4 Missing ⚠️
common/errors.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   64.44%   64.28%   -0.17%     
==========================================
  Files         108      108              
  Lines        7592     7611      +19     
==========================================
  Hits         4893     4893              
- Misses       2372     2391      +19     
  Partials      327      327              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features: