Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging: basic support #214

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Logging: basic support #214

merged 5 commits into from
Nov 21, 2024

Conversation

vitalyisaev2
Copy link
Member

Started work on new LOGGING external datasource.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 22 lines in your changes missing coverage. Please review.

Project coverage is 64.28%. Comparing base (bb20e47) to head (ac507d4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/server/grpc_metrics.go 11.76% 15 Missing ⚠️
app/server/service_connector.go 33.33% 4 Missing ⚠️
common/errors.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   64.44%   64.28%   -0.17%     
==========================================
  Files         108      108              
  Lines        7592     7611      +19     
==========================================
  Hits         4893     4893              
- Misses       2372     2391      +19     
  Partials      327      327              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@vitalyisaev2 vitalyisaev2 merged commit 00a3d65 into main Nov 21, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants